Skip to content

Conversation

Mattias-Sehlstedt
Copy link
Contributor

Fixes #22066

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Mattias-Sehlstedt Mattias-Sehlstedt changed the title [Csharp] Fix how array list types are set when using NULLABLE_REFERENCE_TYPES [CSHARP] Fix how the array type is set when using NULLABLE_REFERENCE_TYPES Oct 3, 2025
@Mattias-Sehlstedt Mattias-Sehlstedt force-pushed the deep-alias-with-optional-collection branch from 9b0123e to ac106df Compare October 3, 2025 20:01
…ignature.yaml and make slight adjustments to include more complex inline array scenarios for NullReferenceTypes
@Mattias-Sehlstedt Mattias-Sehlstedt force-pushed the deep-alias-with-optional-collection branch from ac106df to 611f10c Compare October 3, 2025 20:21
@wing328
Copy link
Member

wing328 commented Oct 5, 2025

cc @mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

cc @devhl-labs

if (ModelUtils.isArraySchema(target)) {
Schema<?> items = getSchemaItems(schema);
return getSchemaType(target) + "<" + getTypeDeclarationForArray(items) + ">";
return typeMapping.get("array") + "<" + getTypeDeclarationForArray(items) + ">";
Copy link
Contributor Author

@Mattias-Sehlstedt Mattias-Sehlstedt Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted this type calculation to the previous static array-mapping, since the more dynamic .getSchemaType(target) could modify the type with ? based upon NULLABLE_REFERENCE_TYPES (which is undesirable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][CSHARP] Regression with collections and nullable types
2 participants